linux-kernel - Re: [PATCH 2/5] tmpfs: mpol=bind:0 don't cause mount error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1268835437.4773.42.camel@useless.americas.hpqcorp.net>
Date:	Wed, 17 Mar 2010 10:17:17 -0400
From:	Lee Schermerhorn <Lee.Schermerhorn@...com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, kiran@...lex86.org,
	cl@...ux-foundation.org, hugh.dickins@...cali.co.uk, mel@....ul.ie,
	stable@...nel.org, linux-mm <linux-mm@...ck.org>,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 2/5] tmpfs: mpol=bind:0 don't cause mount error.

On Tue, 2010-03-16 at 14:50 +0900, KOSAKI Motohiro wrote:
> Currently, following mount operation cause mount error.
> 
> % mount -t tmpfs -ompol=bind:0 none /tmp
> 
> Because commit 71fe804b6d5 (mempolicy: use struct mempolicy pointer in
> shmem_sb_info) corrupted MPOL_BIND parse code.
> 
> This patch restore the needed one.
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> Cc: Ravikiran Thirumalai <kiran@...lex86.org>
> Cc: Christoph Lameter <cl@...ux-foundation.org>
> Cc: Mel Gorman <mel@....ul.ie>
> Cc: Lee Schermerhorn <lee.schermerhorn@...com>
> Cc: Hugh Dickins <hugh.dickins@...cali.co.uk>
> Cc: <stable@...nel.org>

There's a trailing space in the patch, but except for that:

Acked-by: Lee Schermerhorn <lee.schermerhorn@...com>

> ---
>  mm/mempolicy.c |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 25a0c0f..3f77062 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -2220,9 +2220,13 @@ int mpol_parse_str(char *str, struct mempolicy **mpol, int no_context)
>  		if (!nodelist)
>  			err = 0;
>  		goto out;
> -	/*
> -	 * case MPOL_BIND:    mpol_new() enforces non-empty nodemask.
> -	 */
> +	case MPOL_BIND:
> +		/* 
trailing space      ^

> +		 * Insist on a nodelist
> +		 */
> +		if (!nodelist)
> +			goto out;
> +		err = 0;
>  	}
>  
>  	mode_flags = 0;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/