linux-kernel - Re: [PATCH 3/5] tmpfs: handle MPOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100318084915.8723.A69D9226@jp.fujitsu.com>
Date:	Thu, 18 Mar 2010 08:52:23 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Hugh Dickins <hugh.dickins@...cali.co.uk>, lee.schermerhorn@...com
Cc:	kosaki.motohiro@...fujitsu.com,
	LKML <linux-kernel@...r.kernel.org>, kiran@...lex86.org,
	cl@...ux-foundation.org, mel@....ul.ie, stable@...nel.org,
	linux-mm <linux-mm@...ck.org>, akpm@...ux-foundation.org
Subject: Re: [PATCH 3/5] tmpfs: handle MPOL_LOCAL mount option properly

> On Tue, 16 Mar 2010, KOSAKI Motohiro wrote:
> 
> > commit 71fe804b6d5 (mempolicy: use struct mempolicy pointer in
> > shmem_sb_info) added mpol=local mount option. but its feature is
> > broken since it was born. because such code always return 1 (i.e.
> > mount failure).
> > 
> > This patch fixes it.
> > 
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> > Cc: Ravikiran Thirumalai <kiran@...lex86.org>
> 
> Thank you both for finding and fixing these mpol embarrassments.
> 
> But if this "mpol=local" feature was never documented (not even in the
> commit log), has been broken since birth 20 months ago, and nobody has
> noticed: wouldn't it be better to save a little bloat and just rip it out?

I have no objection if lee agreed, lee?
Of cource, if we agree it, we can make the new patch soon :)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/