linux-kernel - Re: Patch inclusion in stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100318121739.GA2390@dhcp-lab-161.englab.brq.redhat.com>
Date:	Thu, 18 Mar 2010 13:17:40 +0100
From:	Stanislaw Gruszka <sgruszka@...hat.com>
To:	Surbhi Palande <Surbhi.Palande@...onical.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable@...nel.org, "John W. Linville" <linville@...driver.com>
Subject: Re: Patch inclusion in stable

On Thu, Mar 18, 2010 at 01:32:33PM +0200, Surbhi Palande wrote:
> Hi All,
> 
> I had a look at the 2.6.32.10 stable patches. Had a comment on the 31st
> patch in the series:
> 
> commit 7ef79e1045213953b87f45cf5993cc9c70c873ec
> Author: Stanislaw Gruszka <sgruszka@...hat.com>
> 
>     airo: fix setting zero length WEP key
> 
> The linux-2.6 source has another patch that adds the following line:
> if (WARN_ON(keylen == 0))
> >> +     return -1;
> 
> This is added through the commit
> 6510b8917948283005a125c8337d3312a8a0561c. This commit is missing in the
> 2.6.32.10 stable patches. I think it should be a part of stable patches
> too.

keylen == 0 is just bug and should never happen. As we are printing
calltrace in such situation user is informed of a bug. Return from
function in that case is nice, but not strictly necessary.

Cheers
Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/