linux-kernel - Re: [PATCH v2 1/7] wireless.h: Add STD_IW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1268933820.2403.25.camel@Joe-Laptop.home>
Date:	Thu, 18 Mar 2010 10:37:00 -0700
From:	Joe Perches <joe@...ches.com>
To:	Pavel Roskin <proski@....org>
Cc:	linux-kernel@...r.kernel.org,
	Richard Kennedy <richard@....demon.co.uk>,
	Johannes Berg <johannes@...solutions.net>,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH v2 1/7] wireless.h: Add STD_IW_HANDLER macro

On Thu, 2010-03-18 at 13:23 -0400, Pavel Roskin wrote:
> On Wed, 2010-03-17 at 23:21 -0700, Joe Perches wrote:
> > Copied from orinoco, initialize a iw_handler array entry
> > +#define STD_IW_HANDLER(id, func) \
> > +	[IW_IOCTL_IDX(id)] = (iw_handler) func
> Three objections.
> 1) STD_IW_HANDLER is a poor name for a header.  The name should start
> with IW, just like those above and below it.

Is IW_HANDLER ok with you?

> 3) Abstracting a cast is bad unless it's the whole purpose of the macro.
> While Orinoco needs the cast, other drivers may not need it.  Using a
> cast could prevent gcc from finding a legitimate problem.

I've no objection to moving the casts to the uses
of the macro where necessary.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/