linux-kernel - Re: [PATCH] staging: winbond: mds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BA1DE50.1080908@cs.helsinki.fi>
Date:	Thu, 18 Mar 2010 10:03:28 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Lars Lindley <lindley@...ote.org>
CC:	gregkh@...e.de, greg@...ah.com, pavel@....cz,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: mds_f.h whitespace corrections.

Lars Lindley kirjoitti:
> I fixed the whitespaces and the C99 comment.
> 
> Signed-off-by: Lars Lindley <lindley@...ote.org>
> ---
>  drivers/staging/winbond/mds_f.h |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h
> index e09dd4b..0d2bccf 100644
> --- a/drivers/staging/winbond/mds_f.h
> +++ b/drivers/staging/winbond/mds_f.h
> @@ -4,17 +4,17 @@
>  #include "wbhal_s.h"
>  #include "core.h"
>  
> -unsigned char Mds_initial(  struct wbsoft_priv *adapter );
> -void Mds_Destroy(  struct wbsoft_priv *adapter );
> -void Mds_Tx(  struct wbsoft_priv *adapter );
> -void Mds_SendComplete(  struct wbsoft_priv *adapter,  PT02_DESCRIPTOR pT02 );
> -void Mds_MpduProcess(  struct wbsoft_priv *adapter,  struct wb35_descriptor *pRxDes );
> +unsigned char Mds_initial(struct wbsoft_priv *adapter);
> +void Mds_Destroy(struct wbsoft_priv *adapter);
> +void Mds_Tx(struct wbsoft_priv *adapter);
> +void Mds_SendComplete(struct wbsoft_priv *adapter, PT02_DESCRIPTOR pT02);
> +void Mds_MpduProcess(struct wbsoft_priv *adapter, struct wb35_descriptor *pRxDes);
>  extern void DataDmp(u8 *pdata, u32 len, u32 offset);
>  
> -// For data frame sending 20060802
> -u16 MDS_GetPacketSize(  struct wbsoft_priv *adapter );
> -void MDS_GetNextPacket(  struct wbsoft_priv *adapter,  struct wb35_descriptor *pDes );
> -void MDS_GetNextPacketComplete(  struct wbsoft_priv *adapter,  struct wb35_descriptor *pDes );
> -void MDS_SendResult(  struct wbsoft_priv *adapter,  u8 PacketId,  unsigned char SendOK );
> +/* For data frame sending */
> +u16 MDS_GetPacketSize(struct wbsoft_priv *adapter);
> +void MDS_GetNextPacket(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes);
> +void MDS_GetNextPacketComplete(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes);
> +void MDS_SendResult(struct wbsoft_priv *adapter, u8 PacketId, unsigned char SendOK);

While you're at it, how about fixing up those CamelCase parameter names 
as well?

			Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/