lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 18 Mar 2010 10:03:08 +0100
From:	Jrn Engel <joern@...lin.logfs.org>
To:	Francois Romieu <romieu@...zoreil.com>,
	Robert Hancock <hancockrwd@...il.com>,
	David Miller <davem@...emloft.net>,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [Regression] r8169: enable 64-bit DMA by default for PCI
	Express devices (v2)

On Wed, 17 March 2010 21:52:06 +0100, Francois Romieu wrote:
> On Tue, Mar 16, 2010 at 09:35:01AM +0100, J�rn Engel wrote:
> [...]
> > I just noticed lspci is also unhappy.
> > 
> > With patch in:
> > Bikini:~# lspci -vv > lspci
> > pcilib: sysfs_read_vpd: read failed: Connection timed out.
> >
> > With patch reverted:
> > Bikini:~# lspci -vv > lspci2
> > Bikini:~# diff -u lspci*
> > --- lspci       2010-03-16 09:03:02.000000000 +0100
> > +++ lspci2      2010-03-16 09:09:36.000000000 +0100
> > @@ -246,7 +246,7 @@
> >                 Vector table: BAR=4 offset=00000000
> >                 PBA: BAR=4 offset=00000800
> >         Capabilities: [cc] Vital Product Data
> > -               Not readable
> > +               Unknown small resource type 00, will not decode more.
> 
> Neither looks good.

Agreed.

> Did lspci output look different with an older kernel ?

Yes.  The relevant hunk is this one.  Different obviously doesn't
mean better. :)

@@ -223,7 +221,7 @@
                Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
                Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
        Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit+
-               Address: 00000000fee0300c  Data: 4169
+               Address: 00000000fee0300c  Data: 4179
        Capabilities: [70] Express (v2) Endpoint, MSI 01
                DevCap: MaxPayload 256 bytes, PhantFunc 0, Latency L0s <512ns, L1 <64us
                        ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-

And for completeness he is the full diff.  The machine was bought on
16 Jun 2009, so this is the oldest kernel I have.  If you want any
specific kernels tested, please tell me which ones.

Bikini:~# uname -a
Linux Bikini 2.6.31-rc2 #193 SMP Sun Mar 14 17:00:08 CET 2010 x86_64 GNU/Linux
Bikini:~# lspci -vv > lspci3
Bikini:~# diff -u lspci[23]
--- lspci2      2010-03-16 09:09:46.000000000 +0100
+++ lspci3      2010-03-18 09:49:21.000000000 +0100
@@ -24,14 +24,12 @@
                Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
 
 00:1c.0 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 1 (rev 01) (prog-if 00 [Normal decode])
-       Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+
+       Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
        Latency: 0, Cache Line Size: 32 bytes
        Bus: primary=00, secondary=02, subordinate=02, sec-latency=0
-       I/O behind bridge: 00001000-00001fff
-       Memory behind bridge: bf700000-bfafffff
        Prefetchable memory behind bridge: 00000000fdf00000-00000000fdffffff
-       Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- <SERR- <PERR-
+       Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
        BridgeCtl: Parity- SERR+ NoISA- VGA- MAbort- >Reset- FastB2B-
                PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
        Capabilities: [40] Express (v1) Root Port (Slot+), MSI 00
@@ -56,14 +54,14 @@
                RootCap: CRSVisible-
                RootSta: PME ReqID 0000, PMEStatus- PMEPending-
        Capabilities: [80] MSI: Enable+ Count=1/1 Maskable- 64bit-
-               Address: fee0300c  Data: 4149
+               Address: fee0300c  Data: 4159
        Capabilities: [90] Subsystem: ASRock Incorporation Device 27d0
        Capabilities: [a0] Power Management version 2
                Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
                Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
        Capabilities: [100] Virtual Channel <?>
        Capabilities: [180] Root Complex Link <?>
-       Kernel driver in use: pcieport
+       Kernel driver in use: pcieport-driver
 
 00:1c.1 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 2 (rev 01) (prog-if 00 [Normal decode])
        Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+
@@ -98,14 +96,14 @@
                RootCap: CRSVisible-
                RootSta: PME ReqID 0000, PMEStatus- PMEPending-
        Capabilities: [80] MSI: Enable+ Count=1/1 Maskable- 64bit-
-               Address: fee0300c  Data: 4151
+               Address: fee0300c  Data: 4161
        Capabilities: [90] Subsystem: ASRock Incorporation Device 27d2
        Capabilities: [a0] Power Management version 2
                Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
                Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
        Capabilities: [100] Virtual Channel <?>
        Capabilities: [180] Root Complex Link <?>
-       Kernel driver in use: pcieport
+       Kernel driver in use: pcieport-driver
 
 00:1d.0 USB Controller: Intel Corporation 82801G (ICH7 Family) USB UHCI Controller #1 (rev 01) (prog-if 00 [UHCI])
        Subsystem: ASRock Incorporation Device 27c8
@@ -223,7 +221,7 @@
                Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
                Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
        Capabilities: [50] MSI: Enable+ Count=1/1 Maskable- 64bit+
-               Address: 00000000fee0300c  Data: 4169
+               Address: 00000000fee0300c  Data: 4179
        Capabilities: [70] Express (v2) Endpoint, MSI 01
                DevCap: MaxPayload 256 bytes, PhantFunc 0, Latency L0s <512ns, L1 <64us
                        ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists