linux-kernel - [PATCH] Fix ecryptfs related OOPs after umount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100319083917.GE16643@lisa.in-ulm.de>
Date:	Fri, 19 Mar 2010 09:39:17 +0100
From:	Christian Ehrhardt <lk@...e.de>
To:	linux-kernel@...r.kernel.org, ecryptfs-devel@...ts.launchpad.net
Cc:	linux-fsdevel@...r.kernel.org
Subject: [PATCH] Fix ecryptfs related OOPs after umount


Hi,

the following patch removes a d_drop in ecryptfs that is bogus IMHO.
This d_drop unhashes a perfectly valid and reachable dentry in the
lower FS. The patch fixes this perfectly reproducible kernel oops:

    https://bugzilla.kernel.org/show_bug.cgi?id=10907

It and may or may not be related to this ecryptfs bug:

   https://bugs.launchpad.net/ecryptfs/+bug/363734

At least the BUG_ON is on a dentry that should not be unhashed but is.

      regards   Christian


Signed-off-by: Christian Ehrhardt <lk@...e.de>

diff --git a/fs/ecryptfs/super.c b/fs/ecryptfs/super.c
index b15a43a..1a037f7 100644
--- a/fs/ecryptfs/super.c
+++ b/fs/ecryptfs/super.c
@@ -85,7 +85,6 @@ static void ecryptfs_destroy_inode(struct inode *inode)
 		if (lower_dentry->d_inode) {
 			fput(inode_info->lower_file);
 			inode_info->lower_file = NULL;
-			d_drop(lower_dentry);
 		}
 	}
 	ecryptfs_destroy_crypt_stat(&inode_info->crypt_stat);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/