linux-kernel - Re: [PATCH -tip v5] tracepoint: Add signal coredump tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100319133352.GC19394@redhat.com>
Date:	Fri, 19 Mar 2010 14:33:52 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Masami Hiramatsu <mhiramat@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, lkml <linux-kernel@...r.kernel.org>,
	systemtap <systemtap@...rces.redhat.com>,
	DLE <dle-develop@...ts.sourceforge.net>,
	Roland McGrath <roland@...hat.com>,
	Jason Baron <jbaron@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Neil Horman <nhorman@...driver.com>
Subject: Re: [PATCH -tip v5] tracepoint: Add signal coredump tracepoint

(add Neil)

On 03/19, Masami Hiramatsu wrote:
>
>  void do_coredump(long signr, int exit_code, struct pt_regs *regs)
>  {
>  	struct core_state core_state;
> -	char corename[CORENAME_MAX_SIZE + 1];
> +	char corename[CORENAME_MAX_SIZE + 1] = "";
>  	struct mm_struct *mm = current->mm;
>  	struct linux_binfmt * binfmt;
>  	struct inode * inode;
> @@ -1802,6 +1803,7 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs)
>  	static atomic_t core_dump_count = ATOMIC_INIT(0);
>  	struct coredump_params cprm = {
>  		.signr = signr,
> +		.file = NULL,
>  		.regs = regs,
>  		.limit = rlimit(RLIMIT_CORE),
>  		/*
> @@ -1815,8 +1817,10 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs)
>  	audit_core_dumps(signr);
>
>  	binfmt = mm->binfmt;
> -	if (!binfmt || !binfmt->core_dump)
> +	if (!binfmt || !binfmt->core_dump) {
> +		retval = -ENOSYS;
>  		goto fail;
> +	}

Oh.

Masami, may I ask you to delay these changes a bit?

This patch conflicts very much with other changes (hopefully in -mm soon)
we are doing.

If your patch comes first, we have to redo 12 patches. Besides, this patch
complicates do_coredump() even more while it really needs the cleanups.

Please see
http://groups.google.com/group/fa.linux.kernel/browse_thread/thread/96f01d85034ca029/3b6bcb9b2d756dbc
I can send you these patches privately if you wish.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/