linux-kernel - Re: [PATCH] scripts/bootgraph.pl: ignore times until the clock is running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BA386FC.2000901@nokia.com>
Date:	Fri, 19 Mar 2010 16:15:24 +0200
From:	Aaro Koskinen <aaro.koskinen@...ia.com>
To:	ext Arjan van de Ven <arjan@...ux.intel.com>,
	ext Tony Lindgren <tony@...mide.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts/bootgraph.pl: ignore times until the clock is
 running

Hi,

Arjan van de Ven wrote:
> On 3/18/2010 10:49, Aaro Koskinen wrote:
>> The clock used for printk.time=1 does not necessarily start running
>> from zero. On such platforms the bootgraph does not work properly as
>> the calculated boottime will be too long.
> 
> can we fix the platform to be smarter instead ? I'd think that's needed anyway for various
> timers etc to actually work well

Hmm, on OMAP I have gotten so used to this "feature" that I never
thought it was a bug. However, I don't think it will affect anything
else than printk time stamps.

Anyway, I sent a fix proposal to linux-omap list:
http://marc.info/?l=linux-omap&m=126900738712041&w=2

>> To correct this, the patch modifies the script to accept only non-zero
>> start times. This ensures the report contains entries only from the
>> period when the clock was running.
>>
>> Signed-off-by: Aaro Koskinen<aaro.koskinen@...ia.com>
> 
> nothing wrong with the patch itself... just sad that it's needed to work around such bugs ;(
> 
> Acked-by: Arjan van de Ven <arjan@...ux.intel.com>

I guess we can forget this patch if we agree the platform behaviour is
not correct.

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/