linux-kernel - Re: [PATCH] gpio: add interrupt handling capability to max732x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Mar 2010 16:41:56 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Marc Zyngier <maz@...terjones.org>
Cc:	Eric Miao <eric.y.miao@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jebediah Huang <jebediah.huang@...il.com>
Subject: Re: [PATCH] gpio: add interrupt handling capability to max732x

On Tue, 16 Mar 2010 11:34:52 +0100
Marc Zyngier <maz@...terjones.org> wrote:

> +static irqreturn_t max732x_irq_handler(int irq, void *devid)
> +{
> +	struct max732x_chip *chip = devid;
> +	uint8_t pending;
> +	uint8_t level;
> +
> +	pending = max732x_irq_pending(chip);
> +
> +	if (!pending)
> +		return IRQ_HANDLED;

Should be IRQ_NONE?

If this device was on a shared interrupt line and the interrupt was
caused by some other device, and this handler is called first then the
incorrect IRQ_HANDLED return could cause the irq core to do wrong things.


> +	do {
> +		level = __ffs(pending);
> +		handle_nested_irq(level + chip->irq_base);
> +
> +		pending &= ~(1 << level);
> +	} while (pending);
> +
> +	return IRQ_HANDLED;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/