| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1269094385-16114-25-git-send-email-w.sang@pengutronix.de> Date: Sat, 20 Mar 2010 15:13:05 +0100 From: Wolfram Sang <w.sang@...gutronix.de> To: kernel-janitors@...r.kernel.org Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, Wolfram Sang <w.sang@...gutronix.de>, Evgeniy Polyakov <johnpol@....mipt.ru> Subject: [PATCH 24/24] w1/masters: fix dangling pointers Fix I2C-drivers which missed setting clientdata to NULL before freeing the structure it points to. Also fix drivers which do this _after_ the structure was freed already. Signed-off-by: Wolfram Sang <w.sang@...gutronix.de> Cc: Evgeniy Polyakov <johnpol@....mipt.ru> --- Found using coccinelle, then reviewed. Full patchset is available via kernel-janitors, linux-i2c, and LKML. --- drivers/w1/masters/ds2482.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c index e5f7441..b92b1c6 100644 --- a/drivers/w1/masters/ds2482.c +++ b/drivers/w1/masters/ds2482.c @@ -484,6 +484,7 @@ exit_w1_remove: w1_remove_master_device(&data->w1_ch[idx].w1_bm); } exit_free: + i2c_set_clientdata(client, NULL); kfree(data); exit: return err; @@ -501,6 +502,7 @@ static int ds2482_remove(struct i2c_client *client) } /* Free the memory */ + i2c_set_clientdata(client, NULL); kfree(data); return 0; } -- 1.7.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists