linux-kernel - Re: [PATCH] staging: winbond: reg.c Coding style fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100320162426.GB28881@bicker>
Date:	Sat, 20 Mar 2010 19:24:26 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Lars Lindley <lindley@...ote.org>
Cc:	gregkh@...e.de, greg@...ah.com, penberg@...helsinki.fi,
	pavel@....cz, harvey.harrison@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: reg.c Coding style fixes.

On Sat, Mar 20, 2010 at 04:14:11PM +0100, Lars Lindley wrote:
> I fixed all problems reported by checkpatch.pl except some
> (a lot of) long lines and some printk:s.
> I removed "commented away" code and version comments.
> 

	[snip]

> -		msleep(10); // Modify 20051221.1.b
> -		Wb35Reg_WriteSync( pHwData, 0x03d4, 0xb8 );// REG_ON RF_RSTN on, and
> -		msleep(10); // Modify 20051221.1.b

	You removed this msleep().

> -
> +	if (pHwData->phy_type <= RF_MAXIM_V1)
> +		Wb35Reg_WriteSync(pHwData, 0x03d4, 0xffffff38);
> +	else {
> +		Wb35Reg_WriteSync(pHwData, 0x03f4, 0xFF5807FF);
> +		Wb35Reg_WriteSync(pHwData, 0x03d4, 0x80); /* regulator on only */
> +		msleep(10);
> +		Wb35Reg_WriteSync(pHwData, 0x03d4, 0xb8); /* REG_ON RF_RSTN on, and msleep(10); */

In the new version it's commented out.                                             ^^^^^^^^^^^^

I used a program to try verify that only white space changed.
http://lkml.indiana.edu/hypermail/linux/kernel/1003.1/01012.html

Then when it failed I grovelled through to find what changed.

Actually my tool complained about removed parenthesis as well.  I think 
this patch only removes one set of parenthesis.  Please don't do that.  
With a patch this size, it's nice to be able to use tools to verify that 
it doesn't change anything, instead of checking it by hand. Tabs, spaces
and newlines only, please.

Obviously in the next patch you can send the one liner that remove the
parenthesis.  We can eyeball one liners quite quickly.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/