linux-kernel - Re: [PATCH 2/4 v2] MFD: add support for the RDC321x southbridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100320125628.6cfcf118.sfr@canb.auug.org.au>
Date:	Sat, 20 Mar 2010 12:56:28 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Florian Fainelli <florian@...nwrt.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Wim Van Sebroeck <wim@...ana.be>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH 2/4 v2] MFD: add support for the RDC321x southbridge

Hi Florian,

On Fri, 19 Mar 2010 13:52:09 -0700 Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> On Thu, 11 Mar 2010 09:42:09 +0100
> Florian Fainelli <florian@...nwrt.org> wrote:
> 
> > +static struct pci_device_id rdc321x_sb_table[] = {
> > +	{ PCI_DEVICE(PCI_VENDOR_ID_RDC, PCI_DEVICE_ID_RDC_R6030) },
> > +	{}
> > +};
> 
> should be const, methinks.

In fact maybe even

static DEFINE_PCI_DEVICE_TABLE(rdc321x_sb_table) = {
	...

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped