linux-kernel - Re: [PATCH] kconfig: recalc symbol value before showing search results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1269121936.5363.199.camel@localhost>
Date:	Sat, 20 Mar 2010 17:52:16 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kbuild@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Michal Marek <mmarek@...e.cz>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] kconfig: recalc symbol value before showing search
 results

On Fri, 2010-03-19 at 14:57 +0800, Li Zefan wrote:
> A symbol's value won't be recalc-ed until we save config file or
> enter the menu where the symbol sits.
> 
> So If I enable OPTIMIZE_FOR_SIZE, and search FUNCTION_GRAPH_TRACER:
> 
>   Symbol: FUNCTION_GRAPH_TRACER [=y]
>   Prompt: Kernel Function Graph Tracer
>     Defined at kernel/trace/Kconfig:140
>     Depends on: ... [=y] && (!X86_32 [=y] || !CC_OPTIMIZE_FOR_SIZE [=y])

[ off topic ]

I'm not sure we need that anymore. I think Thomas added a patch that can
disable the cases that gcc causes the function graph to fail.

I pushed a patch before that also runs a check at compile time to make
sure that gcc does not produce a bad mcount setup that would screw up
the function graph tracer.

http://lkml.org/lkml/2009/11/20/2

It probably still makes sense to add it.

-- Steve

>     ...
> 
> >From the dependency it should result in FUNCTION_GRAPH_TRACER=n,
> but it still shows FUNCTION_GRAPH_TRACER=y.
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>
> ---
>  scripts/kconfig/symbol.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
> index 6c8fbbb..dfef8d1 100644
> --- a/scripts/kconfig/symbol.c
> +++ b/scripts/kconfig/symbol.c
> @@ -750,6 +750,7 @@ struct symbol **sym_re_search(const char *pattern)
>  				return NULL;
>  			}
>  		}
> +		sym_calc_value(sym);
>  		sym_arr[cnt++] = sym;
>  	}
>  	if (sym_arr)
> -- 1.6.3 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/