linux-kernel - Re: [PATCH] staging: winbond: mlmetxrx.c Coding style fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BA4829D.3060600@coyote.org>
Date:	Sat, 20 Mar 2010 09:09:01 +0100
From:	Lars Lindley <lindley@...ote.org>
To:	Pavel Machek <pavel@....cz>
CC:	gregkh@...e.de, greg@...ah.com, penberg@...helsinki.fi,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: mlmetxrx.c Coding style fixes.

Hi!

No problem..It's fun to make a contribution.

On 2010-03-20 01:10, Pavel Machek wrote:
> Hi!
> 
> And thanks for the effort.
>
>> +	adapter->sMlmeFrame.pMMPDU = mmpdu;
> 
> I'm not sure if 'mmpdu' is good name. But I don't know what it stands
> for, either, so...
> 
I have no idea what it is either. Someone who knows what it is might have
a better name up their sleeve..

>> +	adapter->sMlmeFrame.DataType = datatype;
> 
> data_type, please...
> 
> 									Pavel
> 

Fixed..And also send_ok and packet_id..

The generated .o is identical to the one from a clean tree..

Here's a patch that applies after the old one..



[PATCH] staging: winbond: mlmetxrx.c func. argument name change.

I changed some function argument names to make them more readable.

Signed-off-by: Lars Lindley <lindley@...ote.org>
---
 drivers/staging/winbond/mlmetxrx.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/winbond/mlmetxrx.c b/drivers/staging/winbond/mlmetxrx.c
index 76b79f0..a8f4b8b 100644
--- a/drivers/staging/winbond/mlmetxrx.c
+++ b/drivers/staging/winbond/mlmetxrx.c
@@ -19,7 +19,7 @@
  *		FRAME_TYPE_802_11_MANAGEMENT_CHALLENGE,
  *		FRAME_TYPE_802_11_DATA
  */
-u8 MLMESendFrame(struct wbsoft_priv *adapter, u8 *mmpdu, u16 len, u8 datatype)
+u8 MLMESendFrame(struct wbsoft_priv *adapter, u8 *mmpdu, u16 len, u8 data_type)
 {
 	if (adapter->sMlmeFrame.IsInUsed != PACKET_FREE_TO_USE) {
 		adapter->sMlmeFrame.wNumTxMMPDUDiscarded++;
@@ -29,7 +29,7 @@ u8 MLMESendFrame(struct wbsoft_priv *adapter, u8 *mmpdu, u16 len, u8 datatype)
 
 	/* Keep information for sending */
 	adapter->sMlmeFrame.pMMPDU = mmpdu;
-	adapter->sMlmeFrame.DataType = datatype;
+	adapter->sMlmeFrame.DataType = data_type;
 	/* len must be the last setting due to QUERY_SIZE_SECOND of Mds */
 	adapter->sMlmeFrame.len = len;
 	adapter->sMlmeFrame.wNumTxMMPDU++;
@@ -72,7 +72,7 @@ static void MLMEfreeMMPDUBuffer(struct wbsoft_priv *adapter, s8 *data)
 	}
 }
 
-void MLME_SendComplete(struct wbsoft_priv *adapter, u8 packetid, unsigned char sendok)
+void MLME_SendComplete(struct wbsoft_priv *adapter, u8 packet_id, unsigned char send_ok)
 {
 	MLME_TXCALLBACK	TxCallback;
 
-- 
1.7.0.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/