linux-kernel - Re: [PATCH 3/6] staging: winbond: Convert typedef struct _STRUCT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 20 Mar 2010 01:15:06 +0100
From:	Pavel Machek <pavel@....cz>
To:	Sankar P <sankar.curiosity@...il.com>
Cc:	gregkh@...e.de, penberg@...helsinki.fi, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] staging: winbond: Convert typedef struct
	_STRUCT_SELECTOR

On Sat 2010-03-20 02:11:01, Sankar P wrote:
> This patch converts the declaration typedef struct _STRUCT_SELECTOR
> to struct struct_selector and also the places where it was used.
> 
> Signed-off-by: Sankar P <sankar.curiosity@...il.com>

ack.

> ---
>  drivers/staging/winbond/mac_structures.h |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/winbond/mac_structures.h b/drivers/staging/winbond/mac_structures.h
> index 7eb0e57..4130cf6 100644
> --- a/drivers/staging/winbond/mac_structures.h
> +++ b/drivers/staging/winbond/mac_structures.h
> @@ -436,7 +436,7 @@ struct Extended_Supported_Rates_Element
>  #define OUI_CIPHER_CCMP				0x04
>  #define OUI_CIPHER_WEP_104			0x05
>  
> -typedef struct _SUITE_SELECTOR_
> +struct suite_selector
>  {
>  	union
>  	{
> @@ -447,23 +447,23 @@ typedef struct _SUITE_SELECTOR_
>  			u8	Type;
>  		}SuitSelector;
>  	};
> -}SUITE_SELECTOR;
> +};
>  
>  //--  WPA  --
>  struct	RSN_Information_Element
>  {
>  	u8					Element_ID;
>  	u8					Length;
> -	SUITE_SELECTOR	OuiWPAAdditional;//WPA version 2.0 additional field, and should be 00:50:F2:01
> +	struct suite_selector	OuiWPAAdditional; /* WPA version 2.0 additional field, and should be 00:50:F2:01 */
>  	u16					Version;
> -	SUITE_SELECTOR		GroupKeySuite;
> +	struct suite_selector		GroupKeySuite;
>  	u16					PairwiseKeySuiteCount;
> -	SUITE_SELECTOR		PairwiseKeySuite[1];
> +	struct suite_selector		PairwiseKeySuite[1];
>  }__attribute__ ((packed));
>  struct RSN_Auth_Sub_Information_Element
>  {
>  	u16				AuthKeyMngtSuiteCount;
> -	SUITE_SELECTOR	AuthKeyMngtSuite[1];
> +	struct suite_selector	AuthKeyMngtSuite[1];
>  }__attribute__ ((packed));
>  
>  //--  WPA2  --
> @@ -508,16 +508,16 @@ struct	WPA2_RSN_Information_Element
>  	u8					Element_ID;
>  	u8					Length;
>  	u16					Version;
> -	SUITE_SELECTOR		GroupKeySuite;
> +	struct suite_selector		GroupKeySuite;
>  	u16					PairwiseKeySuiteCount;
> -	SUITE_SELECTOR		PairwiseKeySuite[1];
> +	struct suite_selector		PairwiseKeySuite[1];
>  
>  }__attribute__ ((packed));
>  
>  struct WPA2_RSN_Auth_Sub_Information_Element
>  {
>  	u16				AuthKeyMngtSuiteCount;
> -	SUITE_SELECTOR	AuthKeyMngtSuite[1];
> +	struct suite_selector	AuthKeyMngtSuite[1];
>  }__attribute__ ((packed));
>  
>  

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/