linux-kernel - Re: [PATCH v2 6/6] hid: add experimental access to PicoLCD device's EEPROM and FLASH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100321030802.GB29360@core.coreip.homeip.net>
Date:	Sat, 20 Mar 2010 20:08:02 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Bruno Prémont <bonbons@...ux-vserver.org>
Cc:	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Rick L. Vinyard Jr." <rvinyard@...nmsu.edu>,
	Nicu Pavel <npavel@...ner.com>,
	Oliver Neukum <oliver@...kum.org>,
	Jaya Kumar <jayakumar.lkml@...il.com>
Subject: Re: [PATCH v2 6/6] hid: add experimental access to PicoLCD device's
 EEPROM and FLASH

On Sat, Mar 20, 2010 at 05:11:19PM +0100, Bruno Prémont wrote:
> The PicoLCD device has a small amount of EEPROM and also provides
> access to its FLASH where firmware and splash image are saved.
> In flasher mode FLASH access is the only active feature.
> 
> Give read/write access to both via debugfs files.
> 

It looks you are allowing multiple users access to these files. What
will happen if 2 processes try to write EEPROM at the same time?

> +
> +static inline int picolcd_init_devfs(struct picolcd_data *data,
> +		struct hid_report *eeprom_r, struct hid_report *eeprom_w,
> +		struct hid_report *flash_r, struct hid_report *flash_w,
> +		struct hid_report *reset)
> +{

I don't think this should be forced inline.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/