linux-kernel - Re: [PATCH] Route kbd LEDs through the generic LEDs layer (5th version)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100321210938.GB2057@elf.ucw.cz>
Date:	Sun, 21 Mar 2010 22:09:38 +0100
From:	Pavel Machek <pavel@....cz>
To:	Samuel Thibault <samuel.thibault@...-lyon.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	alan@...rguk.ukuu.org.uk, mgarski@...t.pl,
	linux-input@...r.kernel.org, Vojtech Pavlik <vojtech@...e.cz>,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH] Route kbd LEDs through the generic LEDs layer (5th
 version)

Hi!

> Route keyboard LEDs through the generic LEDs layer.
> 
> This permits to reassign keyboard LEDs to something else than keyboard "leds"
> state, by adding keyboard led and modifier triggers connected to a series
> of global input LEDs, themselves connected to global input triggers, which
> per-input device LEDs use by default.  Userland can thus easily change the LED
> behavior of (a priori) all input devices, or of particular input devices.
> 
> This also permits to fix #7063 from userland by using a modifier to implement
> proper CapsLock behavior and have the keyboard caps lock led show that modifier
> state.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>

I like it.

Tested-by: Pavel Machek <pavel@....cz>

Now, minor comments:

sometimes it uses "numl" (led name), sometimes it uses "numlock"
trigger name.

root@amd:/sys/class/leds/input5::numl# echo heartbeat > trigger

did not do the trick on my thinkpad. It still acts as numlock led. Is
it driven by hw? input5::capsl works as expected.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/