linux-kernel - Re: [PATCH] staging: winbond: reg.c Coding style fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BA61384.3030005@cs.helsinki.fi>
Date:	Sun, 21 Mar 2010 14:39:32 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Pavel Machek <pavel@....cz>
CC:	Lars Lindley <lindley@...ote.org>,
	Dan Carpenter <error27@...il.com>, gregkh@...e.de,
	greg@...ah.com, harvey.harrison@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: reg.c Coding style fixes.

Pavel Machek wrote:
>> [PATCH] staging: winbond: reg.c Fix accidental commenting of msleep(10)
>>
>> I accidentaly commented out msleep() in one place.
>> This applies after previous patch:
>> Message-Id: <1269098051-6594-1-git-send-email-lindley@...ote.org>
>>
>> Signed-off-by: Lars Lindley <lindley@...ote.org>
> 
> Ack. but you probably want to merge those two pieces together.

Yes. Like I said before, please _check_ the result before posting your 
patches. It's very easy to make silly mistakes in "trivial" patches like 
these. Remember, it's not about quantity, it's about quality of each 
individual patch no matter how trivial they might seem at first.

			Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/