linux-kernel - Re: [Regression, post-2.6.34-rc1][PATCH] x86 / perf: Fix suspend to RAM on HP nx6325

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1269133835.9440.621.camel@laptop>
Date:	Sun, 21 Mar 2010 02:10:35 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [Regression, post-2.6.34-rc1][PATCH] x86 / perf: Fix suspend
 to RAM on HP nx6325

On Sat, 2010-03-20 at 21:48 +0100, Rafael J. Wysocki wrote:
> On Saturday 20 March 2010, Linus Torvalds wrote:
> > 
> > On Sat, 20 Mar 2010, Peter Zijlstra wrote:
> > >  
> > >  	cpuhw = &per_cpu(cpu_hw_events, cpu);
> > > +	if (!cpuhw)
> > > +		return;
> > 
> > How can an address-of expression be NULL?
> > 
> > Yes, 'per_cpu()' is magic, but it shouldn't be possible to be _that_ 
> > magic. It's rather against the whole C model.
> 
> Yeah.
> 
> A field in the object pointed to by it can be NULL, though.

That's what I was aiming for,. might have missed it by a mile though :/

> The appended patch fixes the breakage for me too.

ok, works for me, thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/