linux-kernel - Re: [PATCH] HID: add driver for Roccat Kone gaming mouse 2nd Attempt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1003220936270.18642@pobox.suse.cz>
Date:	Mon, 22 Mar 2010 09:41:20 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Stefan Achatz <erazor_de@...rs.sourceforge.net>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Stephane Chatty <chatty@...c.fr>,
	Jussi Kivilinna <jussi.kivilinna@...et.fi>, wylda@...ny.cz,
	Michael Poole <mdpoole@...ilus.org>, simon.windows@...il.com,
	Sean Hildebrand <silverwraithii@...il.com>,
	Sid Boyce <sboyce@...eyonder.co.uk>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: add driver for Roccat Kone gaming mouse 2nd
 Attempt

On Thu, 18 Mar 2010, Stefan Achatz wrote:

> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -399,6 +399,9 @@
>  #define USB_VENDOR_ID_PRODIGE		0x05af
>  #define USB_DEVICE_ID_PRODIGE_CORDLESS	0x3062
>  
> +#define USB_VENDOR_ID_ROCCAT		0x1e7d
> +#define USB_DEVICE_ID_ROCCAT_KONE	0x2ced
> +

Hi Stefan,

I guess you also need hid_blacklist[] entry for these device IDs, so that 
generic HID driver doesn't grab the device before your driver gets to it, 
right?

> +static struct hid_driver kone_driver = { .name = "kone",
> +		.id_table = kone_devices, .probe = kone_probe,
> +		.remove = kone_remove, .raw_event = kone_raw_event, };

Could you please put each filed that is being initialized on a separate 
line?

Other than that, the patch looks quite fine to me.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/