linux-kernel - Re: [PATCH v2 2/6] hid: add framebuffer support to PicoLCD device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1003220955000.18642@pobox.suse.cz>
Date:	Mon, 22 Mar 2010 09:56:38 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Bruno Prémont <bonbons@...ux-vserver.org>
Cc:	Jaya Kumar <jayakumar.lkml@...il.com>, linux-input@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-fbdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Rick L. Vinyard Jr." <rvinyard@...nmsu.edu>,
	Nicu Pavel <npavel@...ner.com>,
	Oliver Neukum <oliver@...kum.org>
Subject: Re: [PATCH v2 2/6] hid: add framebuffer support to PicoLCD device

On Sun, 21 Mar 2010, Bruno Prémont wrote:

> > > ---
> > >  drivers/hid/Kconfig       |    7 +-
> > >  drivers/hid/hid-picolcd.c |  454 +++++++++++++++++++++++++++++++++++++++++++++
> > >  2 files changed, 460 insertions(+), 1 deletions(-)
> > 
> > It is customary for framebuffer drivers to live in drivers/video. This
> > is the first one I've reviewed that is outside of it. Is there a good
> > reason for this one to be outside of it? If so, could you put it in
> > the comments.
> 
> I've kept all the pieces of PicoLCD driver together under hid,
> as it's a HID based device. Framebuffer is just one of its features and
> keeping pieces together makes it easier to handle.

I think it makes sense for a HID driver for this device to contain the 
framebuffer bits as well ... from user perspective, this seems to be HID 
device, with "extra" framebuffer display on it.

If framebuffer folks Ack the fb-related code, I am fine keeping it under 
drivers/hid.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/