linux-kernel - Re: [PATCH] staging: winbond: wb35reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Mar 2010 11:57:42 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Lars Lindley <lindley@...ote.org>
Cc:	gregkh@...e.de, greg@...ah.com, pavel@....cz,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: wb35reg_f.h Coding style fixes.

On Mon, Mar 22, 2010 at 11:45 AM, Lars Lindley <lindley@...ote.org> wrote:
> On 2010-03-22 08:16, Pekka Enberg wrote:
>> Lars Lindley kirjoitti:
>>> I fixed the checkpatch things except a couple of long lines.
>>> I also removed hungarian notation from the argument names
>>> and some "commented away" code.
>>>
>>> Signed-off-by: Lars Lindley <lindley@...ote.org>
>>
>> Did you check that all these function declarations are actually used?
>> I've spotted plenty of dead code in the past.
>>
> Nope, didn't check that. Just looking at the style now..

Well, based on my experience, you're will do a lot of unnecessary work
on code that's going to get removed because it's not actually used.
That's why I haven't bothered with style cleanups much.

>>> +/*
>>> + * ====================================
>>> + * Interface function declare
>>> + * ====================================
>>> + */
>>> +unsigned char Wb35Reg_initial(struct hw_data *HwData);
>>
>> Lets avoid CamelCase for the arguments so "hw_data" here, for example. I
>> see the same thing elsewhere in this patch as well.
>>
> I thought struct hw_data *hw_data looked a bit confusing..Thats why I left
> CamelCase alone for now. I can make it like that if you want..

Yes please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/