linux-kernel - Re: [patch] afs: potential null dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12814.1269263124@redhat.com>
Date:	Mon, 22 Mar 2010 13:05:24 +0000
From:	David Howells <dhowells@...hat.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	dhowells@...hat.com, kernel-janitors@...r.kernel.org,
	linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] afs: potential null dereference

Dan Carpenter <error27@...il.com> wrote:

> I was concerned about the dereference here:
> 
> +       if (xpermits)
> +               memcpy(permits->permits, xpermits->permits,
>                                          ^^^^^^^^^^^^^^^^^
> +                       count * sizeof(struct afs_permit));

That's a good point - in which case your patch should definitely go in.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/