linux-kernel - Re: [PATCH 2/2] Updated hid_blacklist, reformatted code and removed unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201003221614.38424.erazor_de@users.sourceforge.net>
Date:	Mon, 22 Mar 2010 16:14:38 +0100
From:	Stefan Achatz <erazor_de@...rs.sourceforge.net>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Stephane Chatty <chatty@...c.fr>,
	Jussi Kivilinna <jussi.kivilinna@...et.fi>, wylda@...ny.cz,
	Michael Poole <mdpoole@...ilus.org>, simon.windows@...il.com,
	Sean Hildebrand <silverwraithii@...il.com>,
	Sid Boyce <sboyce@...eyonder.co.uk>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH 2/2] Updated hid_blacklist, reformatted code and removed unused variable

Am Montag, 22. März 2010 schrieb Jiri Kosina:
> On Mon, 22 Mar 2010, Stefan Achatz wrote:
> > Updated hid_blacklist[] so that generic driver keeps his hands off.
> > Reformatted code so that definition of kone_driver and kone_devices[]
> > have one initialization per line and closing brace is on extra line.
> > Removed an unused variable declaration.
> >
> > Signed-off-by: Stefan Achatz <erazor_de@...rs.sourceforge.net>
> > ---
> >  drivers/hid/hid-core.c        |    1 +
> >  drivers/hid/hid-roccat-kone.c |   15 ++++++++++-----
> >  2 files changed, 11 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > index 368fbb0..dbd6fb8 100644
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -1346,6 +1346,7 @@ static const struct hid_device_id hid_blacklist[] =
> > { { HID_USB_DEVICE(USB_VENDOR_ID_PETALYNX,
> > USB_DEVICE_ID_PETALYNX_MAXTER_REMOTE) }, {
> > HID_USB_DEVICE(USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH)
> > }, { HID_USB_DEVICE(USB_VENDOR_ID_QUANTA,
> > USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN) }, +	{
> > HID_USB_DEVICE(USB_VENDOR_ID_ROCCAT, USB_DEVICE_ID_ROCCAT_KONE) }, {
> > HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_IR_REMOTE) },
> > { HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS3_CONTROLLER)
> > }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SONY,
> > USB_DEVICE_ID_SONY_PS3_CONTROLLER) },
>
> Thanks for the fix. I only wonder how well has the driver been tested, as
> without this change it couldn't get to operate the device at all ... ?
>
> Thanks,

Hi,

As most testing was done with external module compilation on different kernel 
versions with generic hid compiled as internal or as module I have a script 
that uses the drivers sysfs bind/unbind funtionality to switch from generic 
hid to kone driver. Thats issued via udev and was active all the time.

Have a nice day,
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/