linux-kernel - Re: [PATCH] PCI: create function symlinks in /sys/bus/pci/slots/N/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100322181730.GA6310@ldl.fc.hp.com>
Date:	Mon, 22 Mar 2010 12:17:30 -0600
From:	Alex Chiang <achiang@...com>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-pci <linux-pci@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	willy@...ux.intel.com
Subject: Re: [PATCH] PCI: create function symlinks in /sys/bus/pci/slots/N/

* Yinghai Lu <yinghai@...nel.org>:
> On Fri, Mar 19, 2010 at 2:46 PM, Jesse Barnes <jbarnes@...tuousgeek.org> wrote:
> > On Mon, 8 Mar 2010 10:24:29 -0700
> > Alex Chiang <achiang@...com> wrote:
> >
> >> Create convenience symlinks in sysfs, linking slots to device
> >> functions, and vice versa. These links make it easier for users to
> >> figure out which devices actually live in what slots.
> >>
> >> For example:
> >
> > Applied to linux-next, thanks.
> 
> looks this one cause
> 
> [  225.210695] calling  pci_sysfs_init+0x0/0x51 @ 1
> [  225.224774] ------------[ cut here ]------------
> [  225.228913] WARNING: at fs/sysfs/dir.c:451 sysfs_add_one+0xd9/0xf3()
> [  225.245349] Hardware name: Sun Fire x4800
> [  225.247894] sysfs: cannot create duplicate filename
> '/devices/pci0000:00/0000:00:03.0/0000:02:00.0/slot'

That's really not supposed to happen.

It means that somehow, a single pci_dev is associated with
multiple slots.

There are dev_dbg statements in pci_create_slot() that should
display which slots are getting associated with which pci_dev
during initialization.

Can you please turn those debug statements on and send the
output?

Thanks,
/ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/