linux-kernel - Re: [OT] Style Issues / Concerns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wrx45d4d.fsf@basil.nowhere.org>
Date:	Mon, 22 Mar 2010 21:13:06 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	James Kosin <jkosin@...comgrp.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [OT] Style Issues / Concerns

James Kosin <jkosin@...comgrp.com> writes:
>
> Before everyone jumps in at once, this is a simple example that will
> produce a compiler error about the misplaced else.  However if there are
> many if statements above this that may allow the else to be paired up
> with it then the code will compile and there will be a serious and very
> difficult bug in the code that will take days or months to find.

Modern editors with auto indent mode makes it actually very easy
to find such bugs.

Also checkpatch.pl checks for it now I believe.

> Does the compiler produce smaller code without the braces {}?

No, it's very arbitary.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/