[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20100322211147.GQ2873@ghostprotocols.net>
Date: Mon, 22 Mar 2010 18:11:47 -0300
From: Arnaldo Carvalho de Melo <acme@...hat.com>
To: Ingo Molnar <mingo@...e.hu>
Cc: linux-kernel@...r.kernel.org, Avi Kivity <avi@...hat.com>,
Frédéric Weisbecker <fweisbec@...il.com>,
Mike Galbraith <efault@....de>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH 1/1] perf report: newt callgraphs
Em Mon, Mar 22, 2010 at 05:52:49PM -0300, Arnaldo Carvalho de Melo escreveu:
> From: Arnaldo Carvalho de Melo <acme@...hat.com>
>
> Starts collapsed, allows annotating by pressing 'A' or 'a' on the symbol, be it
> the top level one or any of the symbols in the chains.
>
> It (ab)uses the only tree widget in newt, that is actually a checkbox tree that
> we use with just one option ('.'), end result is usable but we really need to
> create a custom widget tree so that we can use the data structures we have
> (hist_entry rb_tree + callchain rb_tree + lists), so that we reduce the memory
> footprint by not creating a mirror set of data structures in the
> newtCheckboxTree widget.
>
> Thanks to Frédéric Weisbacker for fixing the orphanage problem in
> 301fde2, without that we were tripping a newt bug (fix already sent to
> newt's maintainer).
For the curious, here is a screenshot:
http://tglx.de/~acme/perf-newt-callgraph.png
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists