linux-kernel - Re: [PATCH 2/6] drivers:misc: Kconfig, Makefile for TI's ST ldisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <4BA8D9EB.5010103@ti.com>
Date:	Tue, 23 Mar 2010 10:10:35 -0500
From:	Pavan Savoy <pavan_savoy@...com>
To:	gregkh@...e.de, randy.dunlap@...cle.com, pavan_savoy@...com,
	linux-kernel@...r.kernel.org, alan@...rguk.ukuu.org.uk
Subject: Re: [PATCH 2/6] drivers:misc: Kconfig, Makefile for TI's ST ldisc

On Mon, 22 Mar 2010 18:45:42 -0500 Pavan Savoy wrote:

 > [Pavan]>>>>>>>>>>>>>>>
 > I suppose this should be fine ...
 >

 >Well, almost there...

 >
 >  From f12153a01e9f4a1ce2c381319fdfde60daeef461 Mon Sep 17 00:00:00 2001
 > From: Pavan Savoy <pavan_savoy@...com>
 > Date: Mon, 22 Mar 2010 16:40:19 -0400
 > Subject: [PATCH 2/7] drivers:misc: Kconfig, Makefile for TI's ST ldisc
 >
 > This change adds the Kconfig and Make file for TI's
 > ST line discipline driver and the BlueZ driver for BT
 > core of the TI BT/FM/GPS combo chip.
 >
 > Signed-off-by: Pavan Savoy <pavan_savoy@...com>
 > ---
 >   drivers/misc/Kconfig        |    1 +
 >   drivers/misc/Makefile       |    1 +
 >   drivers/misc/ti-st/Kconfig  |   24 ++++++++++++++++++++++++
 >   drivers/misc/ti-st/Makefile |    7 +++++++
 >   4 files changed, 33 insertions(+), 0 deletions(-)
 >   create mode 100644 drivers/misc/ti-st/Kconfig
 >   create mode 100644 drivers/misc/ti-st/Makefile
 >
 > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
 > index 625e3a6..c059bca 100644
 > --- a/drivers/misc/Kconfig
 > +++ b/drivers/misc/Kconfig
 > @@ -344,5 +344,6 @@ source "drivers/misc/c2port/Kconfig"
 >   source "drivers/misc/eeprom/Kconfig"
 >   source "drivers/misc/cb710/Kconfig"
 >   source "drivers/misc/iwmc3200top/Kconfig"
 > +source "drivers/misc/ti-st/Kconfig"
 >
 >   endif # MISC_DEVICES
 > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
 > index c221917..021f282 100644
 > --- a/drivers/misc/Makefile
 > +++ b/drivers/misc/Makefile
 > @@ -30,3 +30,4 @@ obj-$(CONFIG_IWMC3200TOP)      += iwmc3200top/
 >   obj-$(CONFIG_HWLAT_DETECTOR)        += hwlat_detector.o
 >   obj-y                               += eeprom/
 >   obj-y                               += cb710/
 > +obj-y                                += ti-st/
 > diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig
 > new file mode 100644
 > index 0000000..fe5b0e8
 > --- /dev/null
 > +++ b/drivers/misc/ti-st/Kconfig
 > @@ -0,0 +1,24 @@
 > +#
 > +# TI's shared transport line discipline and the protocol
 > +# drivers (BT, FM and GPS)
 > +#
 > +menu "Texas Instruments shared transport line discipline"
 > +    config TI_ST
 > +    tristate "shared transport core driver"
 > +    select FW_LOADER
 > +    help
 > +       This enables the shared transport core driver for TI
 > +       BT / FM and GPS combo chips.This enables protocol drivers
 > +       to register themselves with core and send data, the responses
 > +       are returned to relevant protocol drivers based on their
 > +       packet types.
 > +
 > +    config ST_BT
 > +    tristate "BlueZ bluetooth driver for ST"
 > +    depends on BT
 > +    select TI_ST
 > +    help
 > +       This enables the Bluetooth driver for TI BT/FM/GPS combo devices

 >End sentence with period (missed from first review comments).

 >But please fix all of the Kconfig file as documented in
 >Documentation/CodingStyle, Chapter 10: Kconfig configuration files:

 >       Lines under a "config" definition
 >        are indented with one tab, while help text is indented an 
 >additional two
         spaces.


 > +       This makes use of shared transport line discipline core driver to
 > +       communicate with the BT core of the combo chip.
 > +endmenu
 > diff --git a/drivers/misc/ti-st/Makefile b/drivers/misc/ti-st/Makefile
 > new file mode 100644
 > index 0000000..ad9cff2
 > --- /dev/null
 > +++ b/drivers/misc/ti-st/Makefile
 > @@ -0,0 +1,7 @@
 > +#
 > +# Makefile for TI's shared transport line discipline
 > +# and its protocol drivers (BT, FM, GPS)
 > +#
 > +obj-$(CONFIG_TI_ST) += st_drv.o
 > +st_drv-objs                  := st_core.o st_kim.o st_ll.o
 > +obj-$(CONFIG_ST_BT) += bt_drv.o
 > --
 >---
 >~Randy


[pavan]>>>>>>>
How about this ?

 From 7304d21df4c11244651754976f662d301bef5361 Mon Sep 17 00:00:00 2001
From: Pavan Savoy <pavan_savoy@...com>
Date: Mon, 22 Mar 2010 16:40:19 -0400
Subject: [PATCH 2/7] drivers:misc: Kconfig, Makefile for TI's ST ldisc

This change adds the Kconfig and Make file for TI's
ST line discipline driver and the BlueZ driver for BT
core of the TI BT/FM/GPS combo chip.

Signed-off-by: Pavan Savoy <pavan_savoy@...com>
---
  drivers/misc/Kconfig        |    1 +
  drivers/misc/Makefile       |    1 +
  drivers/misc/ti-st/Kconfig  |   24 ++++++++++++++++++++++++
  drivers/misc/ti-st/Makefile |    7 +++++++
  4 files changed, 33 insertions(+), 0 deletions(-)
  create mode 100644 drivers/misc/ti-st/Kconfig
  create mode 100644 drivers/misc/ti-st/Makefile

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 625e3a6..c059bca 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -344,5 +344,6 @@ source "drivers/misc/c2port/Kconfig"
  source "drivers/misc/eeprom/Kconfig"
  source "drivers/misc/cb710/Kconfig"
  source "drivers/misc/iwmc3200top/Kconfig"
+source "drivers/misc/ti-st/Kconfig"

  endif # MISC_DEVICES
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index c221917..021f282 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -30,3 +30,4 @@ obj-$(CONFIG_IWMC3200TOP)      += iwmc3200top/
  obj-$(CONFIG_HWLAT_DETECTOR)	+= hwlat_detector.o
  obj-y				+= eeprom/
  obj-y				+= cb710/
+obj-y				+= ti-st/
diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig
new file mode 100644
index 0000000..55fc054
--- /dev/null
+++ b/drivers/misc/ti-st/Kconfig
@@ -0,0 +1,24 @@
+#
+# TI's shared transport line discipline and the protocol
+# drivers (BT, FM and GPS)
+#
+menu "Texas Instruments shared transport line discipline"
+config TI_ST
+	tristate "shared transport core driver"
+	select FW_LOADER
+	help
+	  This enables the shared transport core driver for TI
+	  BT / FM and GPS combo chips.This enables protocol drivers
+	  to register themselves with core and send data, the responses
+	  are returned to relevant protocol drivers based on their
+	  packet types.
+
+config ST_BT
+	tristate "BlueZ bluetooth driver for ST"
+	depends on BT
+	select TI_ST
+	help
+	  This enables the Bluetooth driver for TI BT/FM/GPS combo devices.
+	  This makes use of shared transport line discipline core driver to
+	  communicate with the BT core of the combo chip.
+endmenu
diff --git a/drivers/misc/ti-st/Makefile b/drivers/misc/ti-st/Makefile
new file mode 100644
index 0000000..0167d1d
--- /dev/null
+++ b/drivers/misc/ti-st/Makefile
@@ -0,0 +1,7 @@
+#
+# Makefile for TI's shared transport line discipline
+# and its protocol drivers (BT, FM, GPS)
+#
+obj-$(CONFIG_TI_ST) 		+= st_drv.o
+st_drv-objs			:= st_core.o st_kim.o st_ll.o
+obj-$(CONFIG_ST_BT) 		+= bt_drv.o
-- 
1.5.4.3


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/