linux-kernel - Re: [Patch v2] netpoll: warn when there are spaces in parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BA81D18.40509@redhat.com>
Date:	Tue, 23 Mar 2010 09:44:56 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Matt Mackall <mpm@...enic.com>
CC:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	elendil@...net.nl, David Miller <davem@...emloft.net>
Subject: Re: [Patch v2] netpoll: warn when there are spaces in parameters

Matt Mackall wrote:
> On Mon, 2010-03-22 at 04:59 -0400, Amerigo Wang wrote:
>> +			printk(KERN_INFO "%s: warning: whitespace"
>> +					"is not allowed\n", np->name);
> 
> Is it a warning or is it info? If it's a warning, then we probably need
> to add "netpoll" or whatever to the message so that people who've got a
> warning-level threshold will know what it's about.
> 

If you mean KERN_INFO, yeah, I want to keep it in the same level
as other messages around.

Also, I already put "np->name" which will be "netconsole" when
we use netconsole.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/