linux-kernel - Re: [PATCH 3/6] drivers:misc: sources for ST core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100323202821.22f7c7f0@lxorguk.ukuu.org.uk>
Date:	Tue, 23 Mar 2010 20:28:21 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	unlisted-recipients:; (no To-header on input)
Cc:	Pavan Savoy <pavan_savoy@...com>, gregkh@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] drivers:misc: sources for ST core

> > [alan]
> > >What if you have multiple devices at once one in each
> > state ?
> > >Why is this global ?
> > 
> > [pavan]
> > st_gdata required in non-tty calls as well.
> > 
> > [pavan]
> > Can't happen, The chip on doing a UART write will either
> > write whole of BT data or whole of FM, so it can't be in
> > multiple states.

What if you have two chips ?

> > st_gdata not in tty priv data or ldisc_data because there
> > are entry points like st_register/unregister which are
> > EXPORTed requires it.

We need to fix that I think so there is some kind of context that is per
device.

> > If the rest seems fine, please consider it for staging,
> > Will keep reworking on it.

I'm happy with it going that way and that means I can then send patches
and suggestions to clean it up bit by bit.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/