linux-kernel - Re: [PATCH] perf_events: fix remapped count support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd4cb8901003231439k117271d4v89ef2e1139307437@mail.gmail.com>
Date:	Tue, 23 Mar 2010 22:39:34 +0100
From:	Stephane Eranian <eranian@...gle.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, paulus@...ba.org,
	davem@...emloft.net, fweisbec@...il.com, robert.richter@....com,
	perfmon2-devel@...ts.sf.net, eranian@...il.com
Subject: Re: [PATCH] perf_events: fix remapped count support

On Tue, Mar 23, 2010 at 6:41 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Tue, 2010-03-23 at 18:25 +0200, Stephane Eranian wrote:
>>         This patch fixes the remapped counter support such that it now works
>>         on X86 processors.
>
> (could you please not add all this whitespace in front? and make sure
>  it's no wider than 70 chars)
>
I will fix that.

> Also, I wouldn't say it fixes it, it's currently not broken, its plain
> not implemented. So this patch adds support for rdpmc.
>
There you go, then.

>>         For other architectures, e.g., PPC, SPARC, assuming they do offer the ability
>>         to read counts directly from user space, all that is needed is a couple of new
>>         arch specific functions:
>
> Power already supports this, so if you just broke this Paul is going to
> be unhappy.
>
I certainly changed the content of hdr->offset. But I don't see how
PPC could have this working otherwise in the presence of multiplex
and thus when you need the timing information to scale.

I'll wait for Paul's comments, then.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/