linux-kernel - Re: [PATCH] arm: convert arm to arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1269391742.2347.33.camel@localhost>
Date:	Tue, 23 Mar 2010 17:49:02 -0700
From:	john stultz <johnstul@...ibm.com>
To:	Russell King <rmk+lkml@....linux.org.uk>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] arm: convert arm to arch_gettimeoffset()

On Wed, 2010-03-24 at 00:34 +0000, Russell King wrote:
> On Tue, Mar 23, 2010 at 04:05:21PM -0700, John Stultz wrote:
> > Convert arm to use GENERIC_TIME via the arch_getoffset() infrastructure,
> > reducing the amount of arch specific code we need to maintain.
> > 
> > The arm architecture is the last arch that need to be converted.
> 
> Much easier to merge, thanks.
> 
> While looking for a machine to build-test this, I noticed that the IOP/IXP
> platforms have ARCH_USES_GETTIMEOFFSET - yet they select PLAT_IOP which
> in turn selects GENERIC_TIME etc.
> 
> I think ARCH_IOP13XX, ARCH_IOP32X and ARCH_IOP33X shouldn't select
> ARCH_USES_GETTIMEOFFSET - do you agree?

Oh, sorry! I didn't notice the PLAT_IOP was a superset of the IOP
arches, thanks for catching that! 

The generalized rule is: if they have clocksources, then you're right,
ARCH_USES_GETTIMEOFFSET should not be used then (since it disables any
non-jiffies clocksources from being used).

Do you need a new respin removing those lines, or are you comfortable
modifying the patch already sent?

Thanks again for the review and help here!
-john





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/