linux-kernel - Re: [PATCH] x86: remove early_res debug output (was Re: Confusing bootmem messages on bootup)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1003241155510.4242@pobox.suse.cz>
Date:	Wed, 24 Mar 2010 11:56:20 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	Yinghai Lu <yinghai@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86: remove early_res debug output (was Re: Confusing
 bootmem messages on bootup)

On Mon, 22 Mar 2010, Jiri Kosina wrote:

> On Mon, 22 Mar 2010, Ingo Molnar wrote:
> 
> > Please also remove the other KERN_DEBUG leftovers - the #if 0 variants.
> 
> From: Jiri Kosina <jkosina@...e.cz>
> Subject: [PATCH] x86: remove early_res debug output
> 
> Commit 08677214e318297 ("x86: Make 64 bit use early_res instead of bootmem 
> before slab") introduced early_res replacement for bootmem, but left code 
> in __free_pages_memory() which dumps all the ranges that are beeing freed, 
> without any additional information, causing some noise in dmesg during 
> bootup.
> 
> Just remove printing of the ranges, that doesn't provide anything useful 
> anyway.
> 
> While at it, remove other commented-out KERN_DEBUG messages in the 
> NO_BOOTMEM code as well.
> 
> Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> 
> --- 
>  mm/bootmem.c |   13 -------------
>  1 files changed, 0 insertions(+), 13 deletions(-)
> 
> diff --git a/mm/bootmem.c b/mm/bootmem.c
> index d7c791e..9b13446 100644
> --- a/mm/bootmem.c
> +++ b/mm/bootmem.c
> @@ -180,19 +180,12 @@ static void __init __free_pages_memory(unsigned long start, unsigned long end)
>  	end_aligned = end & ~(BITS_PER_LONG - 1);
>  
>  	if (end_aligned <= start_aligned) {
> -#if 1
> -		printk(KERN_DEBUG " %lx - %lx\n", start, end);
> -#endif
>  		for (i = start; i < end; i++)
>  			__free_pages_bootmem(pfn_to_page(i), 0);
>  
>  		return;
>  	}
>  
> -#if 1
> -	printk(KERN_DEBUG " %lx %lx - %lx %lx\n",
> -		 start, start_aligned, end_aligned, end);
> -#endif
>  	for (i = start; i < start_aligned; i++)
>  		__free_pages_bootmem(pfn_to_page(i), 0);
>  
> @@ -428,9 +421,6 @@ void __init free_bootmem_node(pg_data_t *pgdat, unsigned long physaddr,
>  {
>  #ifdef CONFIG_NO_BOOTMEM
>  	free_early(physaddr, physaddr + size);
> -#if 0
> -	printk(KERN_DEBUG "free %lx %lx\n", physaddr, size);
> -#endif
>  #else
>  	unsigned long start, end;
>  
> @@ -456,9 +446,6 @@ void __init free_bootmem(unsigned long addr, unsigned long size)
>  {
>  #ifdef CONFIG_NO_BOOTMEM
>  	free_early(addr, addr + size);
> -#if 0
> -	printk(KERN_DEBUG "free %lx %lx\n", addr, size);
> -#endif
>  #else
>  	unsigned long start, end;
>  

Ingo,

are you going to pick this one up for -rc3 please?

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/