linux-kernel - Re: [PATCH 1/7] serial: TTY: new ldisc for TI BT/FM/GPS chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Mar 2010 19:24:50 -0700
From:	Marcel Holtmann <marcel@...tmann.org>
To:	pavan_savoy@...com
Cc:	gregkh@...e.de, alan@...rguk.ukuu.org.uk,
	linux-kernel@...r.kernel.org, pavan_savoy@...oo.co.in
Subject: Re: [PATCH 1/7] serial: TTY: new ldisc for TI BT/FM/GPS chips

Hi guys,

> A new N_TI_WL line discipline added for TI BT/FM/GPS
> combo chips which make use of same TTY to communicate
> with chip. This is to be made use of individual protocol
> BT/FM/GPS drivers.
> 
> Signed-off-by: Pavan Savoy <pavan_savoy@...com>
> ---
>  include/linux/tty.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/tty.h b/include/linux/tty.h
> index 4409967..8288ee1 100644
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -23,7 +23,7 @@
>   */
>  #define NR_UNIX98_PTY_DEFAULT	4096      /* Default maximum for Unix98 ptys */
>  #define NR_UNIX98_PTY_MAX	(1 << MINORBITS) /* Absolute limit */
> -#define NR_LDISCS		20
> +#define NR_LDISCS		21
>  
>  /* line disciplines */
>  #define N_TTY		0
> @@ -48,6 +48,7 @@
>  #define N_PPS		18	/* Pulse per Second */
>  
>  #define N_V253		19	/* Codec control over voice modem */
> +#define N_TI_WL	20	/* for TI's WL connectivity chips */
>  
>  /*
>   * This character is the same as _POSIX_VDISABLE: it cannot be used as

why is this even targeting staging. I prefer if we have proper review
cycles and get this reviewed this way. This looks like more a shortcut
to get things into the kernel than actually spending the effort to clean
things up.

If this would be just a driver, I wouldn't care, but it tries to assign
official numbers for a line discipline and clearly collides with other
peoples work that are going the proper upstream review cycles.

Greg, I would like to see the rule that if it touches files outside of
drivers/staging/ then it is not eligible for staging.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/