linux-kernel - Re: [PATCH 2/4] iwlwifi: don't include iwl-dev.h from iwl-devtrace.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1269453350.2446.3151.camel@rchatre-DESK>
Date:	Wed, 24 Mar 2010 10:55:50 -0700
From:	reinette chatre <reinette.chatre@...el.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Lee.Schermerhorn@...com" <Lee.Schermerhorn@...com>,
	"cl@...ux-foundation.org" <cl@...ux-foundation.org>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"adobriyan@...il.com" <adobriyan@...il.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"hpa@...or.com" <hpa@...or.com>, "Zhu, Yi" <yi.zhu@...el.com>,
	"ilw@...ux.intel.com" <ilw@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH 2/4] iwlwifi: don't include iwl-dev.h from
 iwl-devtrace.h

On Wed, 2010-03-24 at 01:48 -0700, Tejun Heo wrote:
> iwl-devtrace.h is used to declare and define trace points and
> including iwl-dev.h from the file, which in turn includes other
> generic headers can lead to problems like generating duplicate copies
> of generic trace points depending on the order of includes.  Don't
> include iwl-dev.h from iwl-devtrace.h but include it from its users -
> iwl-io.h and iwl-devtrace.c.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Zhu Yi <yi.zhu@...el.com>
> Cc: Reinette Chatre <reinette.chatre@...el.com>
> Cc: Intel Linux Wireless <ilw@...ux.intel.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> ---

Thank you

Acked-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/