linux-kernel - Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Mar 2010 18:56:04 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Doug Nazar <nazard.lkml@...il.com>
Cc:	Boaz Harrosh <bharrosh@...asas.com>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	"J. Bruce Fields" <bfields@...i.umich.edu>,
	pNFS Mailing List <pnfs@...ux-nfs.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT
 case to use of do_last()

On Wed, Mar 24, 2010 at 02:26:29PM -0400, Doug Nazar wrote:
> I also see it....didn't bisect it yet since I was in a rush and had
> a simple work around. I was doing a git pull between two
> repositories on a NFS 4 w/krb5 security. Got the error about
> .git/objects/pack (error: unable to open object pack directory:
> .git/objects/pack: Is a directory). If I then run 'ls
> .git/objects/pack', and then the 'git pull' again it works.

Very interesting...  The damn thing *is* a directory, which should have
made NFS skip all lookup_instantiate_filp() tricks completely.  IOW, it's
not hitting anything intent-related at that case.

I really wonder where the hell does EISDIR come from; no matter how screwed
the cached attributes are, there's not a lot of places where we can return
that sucker.  It either comes from something in NFS itself, or it's
may_open() getting MAY_WRITE on that object or it has to see O_CREAT in
open_flag.  And acc_mode is not modified after it's set in do_filp_open().
If that calculation (acc_mode by open_flag) would be buggered for O_RDONLY,
we'd be seeing a lot more breakage, starting with ls(1) ;-)

One possibility is that shit hits the fan a bit earlier and git really passes
something odd to that open() as the result of bogus stat(), etc.

Folks, could you try the following: in do_last() move case LAST_DOT:
to immediately after follow_dotdot(nd); and see if that changes anything?
It shouldn't, but if nfs is playing odd tricks with ->d_revalidate() for
directories acting differently depending on LOOKUP_PARENT in flags...

IOW, replace
        case LAST_DOTDOT:  
                follow_dotdot(nd);
                dir = nd->path.dentry;
                if (nd->path.mnt->mnt_sb->s_type->fs_flags & FS_REVAL_DOT) {
                        if (!dir->d_op->d_revalidate(dir, nd)) {
                                error = -ESTALE;
                                goto exit;
                        }
                }
                /* fallthrough */
        case LAST_DOT:
        case LAST_ROOT:
with
        case LAST_DOTDOT:  
                follow_dotdot(nd);
                /* fallthrough */
        case LAST_DOT:
                dir = nd->path.dentry;
                if (nd->path.mnt->mnt_sb->s_type->fs_flags & FS_REVAL_DOT) {
                        if (!dir->d_op->d_revalidate(dir, nd)) {
                                error = -ESTALE;
                                goto exit;
                        }
                }
                /* fallthrough */
        case LAST_ROOT:
and see what'll change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/