| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4BAA842A.6060906@gmail.com> Date: Wed, 24 Mar 2010 22:29:14 +0100 From: Jiri Slaby <jirislaby@...il.com> To: Pavel Machek <pavel@....cz> CC: linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, Nigel Cunningham <ncunningham@...a.org.au>, "Rafael J. Wysocki" <rjw@...k.pl> Subject: Re: [RFC 06/15] PM / Hibernate: swap, remove swap_map_handle usages On 03/24/2010 09:33 PM, Pavel Machek wrote: > On Tue 2010-03-23 17:17:34, Jiri Slaby wrote: >> Some code, which will be moved out of swap.c, needs know nothing about >> swap. There will be also other than swap writers later, so that it >> won't make sense at all. >> >> Make it a global static in swap.c as a singleton. > > I guess I just dislike global static. Logically, methods do operate on > handles, so... Ok, "upper layers" may get a handle via .get_reader/writer. The downside is that they would have to get (void *) and pass (void *) down again. I wanted to avoid that (taking into account that it's a singleton). > I don't see a point and I do not think the change is an improvement. The point was to avoid (void *)'s and save users from transferring pointer as a handle. No matter what, the decision is not up to me, discussion indeed welcome. -- js -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists