linux-kernel - Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100325121610.GB5069@pengutronix.de>
Date:	Thu, 25 Mar 2010 13:16:10 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Henrik Kretzschmar <henne@...htwindheim.de>
Cc:	isdn@...ux-pingi.de, davem@...emloft.net,
	linux@...inikbrodowski.net, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer

Hi Henrik,

thanks for the work. Please, just keep the placement of those attributes
consistent. Otherwise it might be easy to miss:

> -static int sedlbauer_config(struct pcmcia_device *link);
> +static int sedlbauer_config(struct pcmcia_device *link) __devinit ;

Wrong.

> -static int sedlbauer_probe(struct pcmcia_device *link)
> +static int __devinit sedlbauer_probe(struct pcmcia_device *link)
>  {

Right.

(I think checkpatch checks for this, too)

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)