linux-kernel - Re: [PATCH] cfq-iosched: Do not merge queues of BE and IDLE classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100325144528.GW5768@kernel.dk>
Date:	Thu, 25 Mar 2010 15:45:28 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Divyesh Shah <dpshah@...gle.com>
Cc:	linux-kernel@...r.kernel.org, nauman@...gle.com, vgoyal@...hat.com
Subject: Re: [PATCH] cfq-iosched: Do not merge queues of BE and IDLE classes

On Wed, Mar 24 2010, Divyesh Shah wrote:
> even if they are found to be co-operating.
> 
> The prio_trees do not have any IDLE cfqqs on them. cfq_close_cooperator()
> is called from cfq_select_queue() and cfq_completed_request(). The latter
> ensures that the close cooperator code does not get invoked if the current
> cfqq is of class IDLE but the former doesn't seem to have any such checks.
> So an IDLE cfqq may get merged with a BE cfqq from the same group which
> should be avoided.

Thanks, applied.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/