linux-kernel - gpiolib: irq functions not implemented on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <566941124.2751269545764521.JavaMail.root@mail.savoirfairelinux.com>
Date:	Thu, 25 Mar 2010 15:36:04 -0400 (EDT)
From:	Jérôme Oufella 
	<jerome.oufella@...oirfairelinux.com>
To:	Michael Buesch <mb@...sch.de>
Cc:	linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: gpiolib: irq functions not implemented on x86

Hi,

I wrote a gpiolib implementation for Technologic Systems TS-5500 boards (x86)
custom GPIO lines. Some of their GPIO lines are directly hooked to CPU (ElanSC520)
GPIRQ lines, so they can trigger IRQs.

However, looking at arch/x86/include/asm/gpio.h:
/*
 * Not implemented, yet.
 */
static inline int gpio_to_irq(unsigned int gpio)
{
        return -ENOSYS;
}

gpio_to_irq()/irq_to_gpio() are not defined on x86 yet.

Q: Is there a reason not to have it call gpiolib's __gpio_to_irq(), as done 
for other gpiolib functions defined here ? such as

-       return -ENOSYS;
+       return __gpio_to_irq(gpio);

Thanks
Jerome Oufella
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/