linux-kernel - Re: [PATCH v2] PL330: Add PL330 DMA controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b68c6791003251748r1688ffceyb1494dfef8434bb0@mail.gmail.com>
Date:	Fri, 26 Mar 2010 09:48:40 +0900
From:	jassi brar <jassisinghbrar@...il.com>
To:	Kyungmin Park <kyungmin.park@...sung.com>
Cc:	Dan Williams <dan.j.williams@...el.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Joonyoung Shim <jy0922.shim@...sung.com>,
	Linus Walleij <linus.ml.walleij@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ben Dooks <ben-linux@...ff.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] PL330: Add PL330 DMA controller driver

On Fri, Mar 26, 2010 at 9:29 AM, Kyungmin Park
<kyungmin.park@...sung.com> wrote:
> On Fri, Mar 26, 2010 at 8:59 AM, jassi brar <jassisinghbrar@...il.com> wrote:
>> On Fri, Mar 26, 2010 at 8:12 AM, Dan Williams <dan.j.williams@...el.com> wrote:
>>> On Thu, Mar 25, 2010 at 3:27 PM, jassi brar <jassisinghbrar@...il.com> wrote:
>>>> On Fri, Mar 26, 2010 at 12:13 AM, Dan Williams <dan.j.williams@...el.com> wrote:
>>>>> It sounds like you just need to add an extension for the arch specific dma
>>>>> api.
>>>> I actually plan more than that.
>>>> Apart from inefficient design, JoonYoung's driver has made some fatal
>>>> assumptions
>>>> about PL330, which will result in DMA aborts if used with SoCs that implement
>>>> configuration of PL330 that is very different from Samsung SoCs'
> Exactly what? We are already tested it our board and play the music well.
> What's condition DMA aborts are happen?
I didn't want to get into gory details, but it seems I need to explain .....

Please see my quick review to the original patch in this thread.
We take the discussion there.

>>>> Of course, I address all such issues that I can think of, in my implementation.
>>>
>>> Ok, I'll rely on acked-by's from the interested parties once your
>>> driver is out as I do not have a vested interest in this hardware,
>>> just the dmaengine framework issues.
>> Fair enough. Thank you.
>
> As your previous mail, we can wait until this weekend. but If you
> don't post the your codes until this weekend.
> We assume that your works are not yet done so merge this patch first
> and then fix it if your words(DMA aborts issue) are right.
It's not upto you to give me any deadline. Not the "Until this weekend" one !!!
I think only the word of the maintainers count.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/