linux-kernel - Re: [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100326080048.GB27394@elte.hu>
Date:	Fri, 26 Mar 2010 09:00:48 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrea Gelmini <andrea.gelmini@...ma.net>
Cc:	linux-doc@...r.kernel.org, Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Tom Zanussi <tzanussi@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/16] Tools perf builtin-trace.c: duplicated includes


* Andrea Gelmini <andrea.gelmini@...ma.net> wrote:

> tools/perf/builtin-trace.c: util/exec_cmd.h and util/trace-event.h are included more than once.
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@...ma.net>
> ---
>  tools/perf/builtin-trace.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 407041d..3c699c5 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -59,9 +59,6 @@ static int cleanup_scripting(void)
>  #include "perf.h"
>  #include "util/debug.h"
>  
> -#include "util/trace-event.h"
> -#include "util/exec_cmd.h"
> -
>  static char const		*input_name = "perf.data";
>  
>  static int process_sample_event(event_t *event, struct perf_session *session)

Please send a more complete patch that fixes the root cause of the 
duplication: a few header files are in the middle of the .c file - all 
inclusions should be at the top of the file.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/