linux-kernel - Re: 2.6.34-rc1: pci_register_set_vga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BACB9DD.6000103@s5r6.in-berlin.de>
Date:	Fri, 26 Mar 2010 14:42:53 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Mike Travis <travis@....com>, "H. Peter Anvin" <hpa@...or.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: 2.6.34-rc1: pci_register_set_vga_state section mismatch

Stefan Richter wrote:
>> WARNING: drivers/pci/built-in.o(__ksymtab+0x320): Section mismatch in reference from the variable __ksymtab_pci_register_set_vga_state to the function .init.text:pci_register_set_vga_state()                                                                                
>> The symbol pci_register_set_vga_state is exported and annotated __init                    
>> Fix this by removing the __init annotation of pci_register_set_vga_state or drop the export.                                                                                        
> 
> This is obviously introduced by commit
>     95a8b6efc5d07103583f706c8a5889437d537939
>     pci: Update pci_set_vga_state() to call arch functions

PS:
There is only a single user of this symbol in the mainline at the
moment, arch/x86/kernel/apic/x2apic_uv_x.c, controlled by
arch/x86/Kconfig:config X86_UV, which allows only static linking.
I.e. the warning is a false positive for now.  But given how small
pci_register_set_vga_state() is, it appears appropriate to drop the
__init annotation.
-- 
Stefan Richter
-=====-==-=- --== ==-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/