linux-kernel - Re: [PATCH] staging: winbond: wb35rx.c Coding style fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100326150618.GA20225@bicker>
Date:	Fri, 26 Mar 2010 18:06:18 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Lars Lindley <lindley@...ote.org>
Cc:	gregkh@...e.de, greg@...ah.com, penberg@...helsinki.fi,
	pavel@....cz, linville@...driver.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: wb35rx.c Coding style fixes.

On Thu, Mar 25, 2010 at 11:13:59PM +0100, Lars Lindley wrote:
> I fixed checkpatch issues except for long lines and printk:s.
> I also removed version comments and the () in a return statement.
> Generated .o is identical to master and i checked the code with
> Dan Carpenters strip_whitespace.pl and diff.
> 
> Signed-off-by: Lars Lindley <lindley@...ote.org>
> ---

	[ snip ]
  			}
>  
> -			// Start to process Rx buffer
> -//			RxDes.Descriptor_ID = RxBufferId; // Due to synchronous indicate, the field doesn't necessary to use.
> -			BufferSize -= 8; //subtract 8 byte for 35's USB header length
> +			/*
> +			 * Start to process Rx buffer
> +			 * RxDes.Descriptor_ID = RxBufferId;
> +			 * Due to synchronous indicate, the field doesn't
> +			 * necessary to use.
> +			 */
> +			BufferSize -= 8; /* subtract 8 byte for 35's USB header length */

Perhaps something like:

	Wb35Rx_indicate() is called synchronously so it isn't necessary to
	set "RxDes.Descriptor_ID = RxBufferId;"

It's still not totally clear but it's a little bit clearer.

Otherwise, looks good.

Acked-by: Dan Carpenter <error27@...il.com>

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/