linux-kernel - Re: [PATCH] rfkill: core: add custom rfkill switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1269623558.4342.0.camel@jlt3.sipsolutions.net>
Date:	Fri, 26 Mar 2010 10:12:38 -0700
From:	Johannes Berg <johannes@...solutions.net>
To:	Pavan Savoy <pavan_savoy@...oo.co.in>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rfkill: core: add custom rfkill switch

On Fri, 2010-03-26 at 21:43 +0530, Pavan Savoy wrote:

> Well, Almost, I don't want to signal the user-space about the counter.
> Have a look @ http://lkml.org/lkml/2010/3/24/303
> 
> See the kernel space (bluetooth driver) would register itself, to my line discipline driver, when someone does a 'hciconfig hci0 up' which is essentially BT-On.
> 
> So, now from my ldisc driver (which intends to mux BT/FM and GPS over UART), I need to signal a user-space daemon to open the TTY device, set the baud rate and install the ldisc - So I can make use of it.
> 
> To notify that user-space daemon, I had planned to use /dev/rfkill.
> However, now with BT application also toggling the rfkill switch by writing to sysfs entry - is causing a bit of confusion to my user-space daemon.
> 
> Although I now use hard/soft members of struct rfkill_event now to differentiate the 2 events (1 auto generated, another from BT app) - This patch would make it a bit more proper.

No. The proper way would be to either have your driver manage the UART
instead of userspace, or have your driver have its own userspace
interface. rfkill has nothing to do with it.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/