linux-kernel - Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Mar 2010 18:57:07 -0300
From:	Marcelo Jimenez <mroberto@...i.cetuc.puc-rio.br>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Sergei Shtylyov <sshtylyov@...sta.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-pcmcia@...ts.infradead.org,
	Wolfram Sang <w.sang@...gutronix.de>,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c

On Fri, Mar 26, 2010 at 15:18, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:
> On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote:
>>
>>   I'd disagree in this case. Anybody will hardly grep for "mask:
>> %s%s%s%s%s%sflags: %s%s%s%s%s%s".
>
> Well, I disagree on a matter of principle with you.  If you want to avoid
> the line going over 80 columns, move the entire string onto the next line.
> Then we can have the entire string intact _and_ we can have it fitting
> within 80 columns.

This is no big deal. Also, I have already submitted the new patch and
Valdis had a good point for egrep.

Regards,
Marcelo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/