linux-kernel - Re: [microblaze-uclinux] Re: [PATCH 3/4] dmaengine: xlldma platform bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa686aa41003261527g434b1971k35422f91479d2e11@mail.gmail.com>
Date:	Fri, 26 Mar 2010 16:27:29 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	steve@...idescorp.com
Cc:	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org, monstr@...str.eu,
	microblaze-uclinux@...e.uq.edu.au
Subject: Re: [microblaze-uclinux] Re: [PATCH 3/4] dmaengine: xlldma platform 
	bus driver

On Fri, Mar 26, 2010 at 4:20 PM, Steven J. Magnani
<steve@...idescorp.com> wrote:
> On Fri, 2010-03-26 at 15:33 -0600, Grant Likely wrote:
>> On Wed, Mar 17, 2010 at 10:26 AM, Steven J. Magnani
>> <steve@...idescorp.com> wrote:
>> > Platform bus attachment for the Xilinx MPMC Soft Direct Memory
>> > Access Controller DMA engine.
>> >
>> > Signed-off-by: Steven J. Magnani <steve@...idescorp.com>
>> > ---
>> > diff -uprN a/drivers/dma/xlldma_plat.c b/drivers/dma/xlldma_plat.c
>> > --- a/drivers/dma/xlldma_plat.c 1969-12-31 18:00:00.000000000 -0600
>> > +++ b/drivers/dma/xlldma_plat.c 2010-03-17 11:11:16.000000000 -0500
>>
>> Not really worth putting into a separate file.  Just put this hunk in
>> the xlldma.c file to keep a few more symbols out of the global
>> namespace.
>
> I can certainly do that, but as someone who's had to add platform bus
> attachments to drivers that only have OF attachments, I can say from
> experience that the result ends up being rather messy. I thought
> (explicitly) decoupling the bus logic from the driver might be an
> improvement. Maybe it's not enough of a benefit.

of_platform is geting merged with platform bus so this issue is going
away.  Just put it all in one file.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/