linux-kernel - Re: [PATCH 01/24] x86: Make smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100326233315.GC29222@cmpxchg.org>
Date:	Sat, 27 Mar 2010 00:33:15 +0100
From:	Johannes Weiner <hannes@...xchg.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 01/24] x86: Make smp_locks end with page alignment

On Fri, Mar 26, 2010 at 03:21:31PM -0700, Yinghai Lu wrote:
> Try to fix
> ------------[ cut here ]------------
> WARNING: at arch/x86/mm/init.c:342 free_init_pages+0x4c/0xfa()
> free_init_pages: range [0x40daf000, 0x40db5c24] is not aligned
> Modules linked in:
> Pid: 0, comm: swapper Not tainted 2.6.34-rc2-tip-03946-g4f16b23-dirty #50
> Call Trace:
>  [<40232e9f>] warn_slowpath_common+0x65/0x7c
>  [<4021c9f0>] ? free_init_pages+0x4c/0xfa
>  [<40881434>] ? _etext+0x0/0x24
>  [<40232eea>] warn_slowpath_fmt+0x24/0x27
>  [<4021c9f0>] free_init_pages+0x4c/0xfa
>  [<40881434>] ? _etext+0x0/0x24
>  [<40d3f4bd>] alternative_instructions+0xf6/0x100
>  [<40d3fe4f>] check_bugs+0xbd/0xbf
>  [<40d398a7>] start_kernel+0x2d5/0x2e4
>  [<40d390ce>] i386_start_kernel+0xce/0xd5
> ---[ end trace 4eaa2a86a8e2da22 ]---
> 
> Comments in vmlinux.lds.S already said:
> |        /*
> |         * smp_locks might be freed after init
> |         * start/end must be page aligned
> |         */
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>

FWIW, Acked-by: Johannes Weiner <hannes@...xchg.org>

> ---
>  arch/x86/kernel/vmlinux.lds.S |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index 44879df..2cc2497 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -291,8 +291,8 @@ SECTIONS
>  	.smp_locks : AT(ADDR(.smp_locks) - LOAD_OFFSET) {
>  		__smp_locks = .;
>  		*(.smp_locks)
> -		__smp_locks_end = .;
>  		. = ALIGN(PAGE_SIZE);
> +		__smp_locks_end = .;
>  	}
>  
>  #ifdef CONFIG_X86_64
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/