linux-kernel - Re: [RFC PATCH 2/7] perf: add pipe-specific header read/write and event processing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100327031455.GN7166@nowhere>
Date:	Sat, 27 Mar 2010 04:14:57 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Tom Zanussi <tzanussi@...il.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, rostedt@...dmis.org,
	k-keiichi@...jp.nec.com
Subject: Re: [RFC PATCH 2/7] perf: add pipe-specific header read/write and
	event processing code

On Wed, Mar 03, 2010 at 01:05:24AM -0600, Tom Zanussi wrote:
>  
> +int perf_header__write_pipe(struct perf_header *self, int fd)
> +{
> +	struct perf_file_header_pipe f_header;
> +	int err;
> +
> +	f_header = (struct perf_file_header_pipe){
> +		.magic	   = PERF_MAGIC,
> +		.size	   = sizeof(f_header),
> +	};
> +
> +	err = do_write(fd, &f_header, sizeof(f_header));
> +	if (err < 0) {
> +		pr_debug("failed to write perf pipe header\n");
> +		return err;
> +	}
> +
> +	self->frozen = 1;
> +	return 0;
> +}



I actually wonder why you bother with a header in the pipe mode,
since it only contains MAGIC and its size.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/